Skip to content

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Jan 24, 2023

Description

Currently, there is no way to use the toolbar to get from viewing a published version of a page (or other object) back to its preview. The only option available is "Edit" which will create a new draft or go to an existing draft.

With this PR the view published mode will have an additional button to get (back) to the preview.

I expect it to create more transparency on the modes available with djangocms-verisoning

  • Edit mode (as with the core): Visible to staff only
  • Preview mode (incldeing draft content): Visible to staff only
  • Published mode (only published content): Visible to the outside

Also there are use cases where published versions and the preview of a public version need to be compared:

  • The published version only contains public versioned items
  • The preview of a public version contains draft versions of, e.g., versioned alias objects

preview

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #316 (b1875ac) into master (33a28c9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
+ Coverage   89.88%   89.91%   +0.02%     
==========================================
  Files          68       68              
  Lines        2244     2250       +6     
  Branches      299      301       +2     
==========================================
+ Hits         2017     2023       +6     
  Misses        172      172              
  Partials       55       55              
Impacted Files Coverage Δ
djangocms_versioning/cms_toolbars.py 95.85% <100.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fsbraun fsbraun merged commit 906d501 into django-cms:master Jan 24, 2023
@fsbraun fsbraun deleted the feat/preview_button branch January 27, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants