feat: Huge performance improvement for admin_manager #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… now as current_content as filter for the latest draft/published
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
=======================================
Coverage 89.91% 89.91%
=======================================
Files 68 68
Lines 2250 2251 +1
Branches 301 300 -1
=======================================
+ Hits 2023 2024 +1
Misses 172 172
Partials 55 55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Feb 4, 2023
vinitkumar
approved these changes
Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
admin_managerof a versioned model provided access tocurrent_content_iteratorwhich allowed to "filter" out all current versions of the model: Either draft or published (if there is no draft). This API had the drawback that the result was not a queryset but an iterator (since the grouping was done in python).This method is now replaced by
current_content()which is a filter that returns a queryset that only contains the current verison of the objects. Not only is it more convenient to have a qs returned, the number of database hits reduces from O(n) with n being the number of objects to 1.current_content_iteratoris kept to ensure compatibility with django CMS v4.1.0rc1Related resources
Checklist
masterSlack to find a “pr review buddy” who is going to review my pull request.