feat: Added bulk delete to version change view #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #338 +/- ##
==========================================
+ Coverage 90.88% 91.21% +0.32%
==========================================
Files 72 72
Lines 2546 2663 +117
Branches 361 307 -54
==========================================
+ Hits 2314 2429 +115
+ Misses 168 163 -5
- Partials 64 71 +7 ☔ View full report in Codecov by Sentry. |
fsbraun
reviewed
Jun 12, 2023
601944c to
1deb2b7
Compare
…s-djangocms-versioning
…s-djangocms-versioning
Do not delete anything if a published or draft version is amongst the selected objects
Update the queryset to contain content elements
|
@polyccon I updated your PR. People keep asking for this feature! I guess you were 80% there. I hope you do not mind, that I added some stuff to finish this. |
fsbraun
reviewed
Oct 29, 2024
| @@ -1388,7 +1419,7 @@ | |||
| .latest("created") | |||
| .content | |||
| ) | |||
| except ObjectDoesNotExist: | |||
| except (ObjectDoesNotExist, KeyError): | |||
Check notice
Code scanning / CodeQL
Empty except Note
fsbraun
reviewed
Oct 29, 2024
|
Nice work @fsbraun thank you for your hard work to bring it over the finish line!!!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
*- Initial draft on adding functionality to bulk delete to versions djangocms versioning
*- More information required on the ticket that needs to be a user story - see link below
Related resources
Checklist
masterSlack to find a “pr review buddy” who is going to review my pull request.