fix: PageContent extension's copy_relations method not called
#344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jacob Rief <jacob.rief@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #344 +/- ##
==========================================
- Coverage 90.90% 90.86% -0.04%
==========================================
Files 72 72
Lines 2530 2530
Branches 356 356
==========================================
- Hits 2300 2299 -1
Misses 170 170
- Partials 60 61 +1
☔ View full report in Codecov by Sentry. |
marksweb
approved these changes
Sep 22, 2023
|
This needs an update as there's conflicts with the main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #342 and is based on #343.
CMS extensions have a
copymethod. It also takes care of callingcopy_relations.djangocms-versioning needs not recreate this method where it can miss the call of
copy_relationsbut instead can use the original method instead.Related resources
Checklist
masterSlack to find a “pr review buddy” who is going to review my pull request.