Skip to content

fix: Several fixes for the versioning forms: #382, #383, #384 #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Mar 5, 2024

Description

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.88%. Comparing base (f90c5b2) to head (9316e4e).
Report is 5 commits behind head on master.

❗ Current head 9316e4e differs from pull request most recent head 98ee4b2. Consider uploading reports for the commit 98ee4b2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
- Coverage   90.88%   90.88%   -0.01%     
==========================================
  Files          72       72              
  Lines        2546     2545       -1     
  Branches      361      361              
==========================================
- Hits         2314     2313       -1     
  Misses        168      168              
  Partials       64       64              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun fsbraun requested a review from a team March 5, 2024 11:43
Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants