Skip to content

Conversation

joshyu
Copy link
Contributor

@joshyu joshyu commented Apr 3, 2024

Description

Below two PRs should be compatible with djangocms 4.0.1.x version, so I cherry-pick them and merge into support/django-cms-4.0.x branch.

Checklist

  • I have opened this pull request against support/django-cms-4.0.x
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.33%. Comparing base (3b3a838) to head (9637cbe).

Additional details and impacted files
@@                    Coverage Diff                    @@
##           support/django-cms-4.0.x     #399   +/-   ##
=========================================================
  Coverage                     84.33%   84.33%           
=========================================================
  Files                            71       71           
  Lines                          2145     2145           
  Branches                        252      252           
=========================================================
  Hits                           1809     1809           
  Misses                          273      273           
  Partials                         63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun fsbraun merged commit 405e9da into django-cms:support/django-cms-4.0.x Apr 3, 2024
@joshyu joshyu deleted the feat/merge-missing-publish-updates branch April 3, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants