Skip to content

fix: Test compatibility with django CMS 5 #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2025
Merged

fix: Test compatibility with django CMS 5 #453

merged 2 commits into from
Mar 4, 2025

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Mar 4, 2025 •
edited
Loading

Description

This PR fixes tests to run with django CMS 5.

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

Summary by Sourcery

Make tests compatible with django CMS 5.

Tests:

  • Allow status code 200 in addition to 302 in test_delete_plugin to support django CMS < 5.
  • Handle AttributeError when setting page languages to support django CMS < 5.

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Mar 4, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request updates the test suite to be compatible with django CMS 5. It addresses an AttributeError that arises when setting the languages attribute on a page object and adjusts the expected status codes in the test_delete_plugin test case to accommodate changes in django CMS 5.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Addresses an AttributeError when setting the languages attribute on a page object.
  • Wrapped the setting of self.page.languages in a try-except block to catch the AttributeError.
  • The AttributeError is caught when the languages attribute does not exist.
 tests/test_integration_with_core.py
Adjusts the expected status codes in the test_delete_plugin test case.
  • Modified the assertion to check if the response status code is either 200 or 302.
  • Added a comment explaining that 302 is expected for django CMS versions prior to 5.
 tests/test_handlers.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@fsbraun fsbraun requested a review from vinitkumar March 4, 2025 07:34
sourcery-ai[bot]
sourcery-ai bot reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fsbraun - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using django.VERSION to conditionally execute code based on the Django version.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov Codecov
Copy link

codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.54%. Comparing base (6cd61a4) to head (0ecf64c).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
+ Coverage   89.77%   90.54%   +0.77%     
==========================================
  Files          72       72              
  Lines        2719     2719              
  Branches      318      318              
==========================================
+ Hits         2441     2462      +21     
+ Misses        201      182      -19     
+ Partials       77       75       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 4, 2025
View reviewed changes
vinitkumar
vinitkumar reviewed Mar 4, 2025
View reviewed changes
Copy link
Member

@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment.

fsbraun
fsbraun commented Mar 4, 2025
View reviewed changes
@fsbraun fsbraun merged commit bf89036 into master Mar 4, 2025
99 checks passed
@fsbraun fsbraun deleted the fix/test-djangocms-5 branch March 4, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@vinitkumar vinitkumar vinitkumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsbraun @vinitkumar