Add show_toolbar_with_docker function for Docker IP handling #2123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new function, show_toolbar_with_docker, to determine if the toolbar should be displayed when running inside Docker containers. - Updated installation documentation to reference the new function for Docker configurations. - Added a changelog entry for the new functionality.
matthiask
reviewed
Apr 9, 2025
| * Add hook to RedirectsPanel for subclass customization | ||
| * Added ``show_toolbar_with_docker`` function to check Docker host IP address | ||
| when running inside Docker containers. | ||
|
|
There was a problem hiding this comment.
The first entry seems to be a duplicate of something old?
The second entry is good, but it should go up into the "Pending" section.
| @@ -155,7 +155,7 @@ option. | |||
| If using Docker, the toolbar will attempt to look up your host name | |||
| automatically and treat it as an allowable internal IP. If you're not | |||
| able to get the toolbar to work with your docker installation, review | |||
| the code in ``debug_toolbar.middleware.show_toolbar``. | |||
| the code in ``debug_toolbar.middleware.show_toolbar_with_docker``. | |||
There was a problem hiding this comment.
So, that warning has to be reworked. Something like:
"If using Docker you can use debug_toolbar.middleware.show_toolbar_with_docker which attempts to automatically look up the Docker gateway IP and treat it as an allowable internal IP so that the toolbar is shown to you."
|
Hi @blingblin-g |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2113
Checklist:
docs/changes.rst.