Fixes #1652 #1860
Open
Fixes #1652 #1860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you whomever authorized the test runs. I'm seeing the same fails on main as well. I've marked them as failing in my new commit. If anyone has the time I'd appreciate any additional context or link to existing discussion about the status of the tests. Great project would be happy to contribute more. |
This was referenced Aug 28, 2024
|
Would you mind updating the PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this issue myself, figured I would PR it instead of adding a comment.
Thanks to @danaspiegel for opening the issue.
Fixes #1652