1817 - Fixing SearchQuerySet to use all given words in db search #1820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbdlin
previously approved these changes
Nov 2, 2021
gbdlin
approved these changes
Nov 3, 2021
2 tasks
9a55a7b to
12b0812
Compare
e0f6869 to
4781950
Compare
With this fix, when a string containing more than one word is passed to the SearchQuerySet filter, a database query will be created that uses all the specified words and combines them into a single WHERE clause. The returned result should be all records that contain all those specified words.
This reverts commit 8e635ad.
With this fix, when a string containing more than one word is passed to the SearchQuerySet filter, a database query will be created that uses all the specified words and combines them into a single WHERE clause. The returned result should be all records that contain all those specified words.
4781950 to
fdff906
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix, when a string containing more than one word is passed to the SearchQuerySet filter, a database query will be created in the way to use all the specified words and combines them into a single WHERE clause. The returned result should be all records that contain all those specified words.
All details are described in the issue: 1817