Skip to content

GitHub Actions: Add Python 3.10 and 3.11 to the testing #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2023
Merged

GitHub Actions: Add Python 3.10 and 3.11 to the testing #1855

merged 2 commits into from
Apr 16, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 18, 2022 •
edited
Loading

'3.10' must be quoted in YAML. https://dev.to/hugovk/the-python-3-1-problem-85g

@cclauss cclauss changed the title GitHub Actions: Add Python 3.10 to the testing GitHub Actions: Add Python 3.10 and 3.11 to the testing Nov 21, 2022
@manelclos
Copy link

@cclauss tests are failing, can you please take a look?

@cclauss
Copy link
Contributor Author

cclauss commented Nov 21, 2022 •
edited
Loading

There are two kinds of problems...

  1. The flake8 errors look easy to fix. --> Fix flake8: logging.error(exc_info=True) --> logging.exception() #1862
  2. The Py310 & Py311 errors look like they are caused by Nose not supporting new Python versions. Two ways to go...
    1. Nose2 which is more difficult to move to than the name makes it sound.
    2. https://pypi.org/project/nose2pytest which is difficult to run but is probably a better long-term bet.

Pull requests to come...

@claudep
Copy link
Contributor

claudep commented Nov 21, 2022

Note that #1837 is aiming at getting rid of nose. I guess that would be the PR to finish to solve recent Python failures.

@cclauss
Copy link
Contributor Author

cclauss commented Nov 21, 2022

Given https://docs.djangoproject.com/en/4.1/faq/install what do we really want to test?
Can we drop Django < 3.2?
Can we drop Python < 3.7? Or < 3.8?
Can we drop Django-Haystack < 5.5?

@cclauss cclauss marked this pull request as draft November 21, 2022 15:42
@cclauss cclauss marked this pull request as ready for review April 12, 2023 14:44
@cclauss cclauss mentioned this pull request Apr 12, 2023
Merged
2 tasks
claudep
claudep reviewed Apr 12, 2023
View reviewed changes
@claudep
Copy link
Contributor

claudep commented Apr 12, 2023

Do you intend to continue improving the patch to reduce failures, or do you think we should go ahead and fix failures in further PRs?

@claudep
Copy link
Contributor

claudep commented Apr 14, 2023

FYI I approved and merged the pre-commit auto-update. You may rebase on latest master.

@acdha acdha merged commit 6040cae into django-haystack:master Apr 16, 2023
@cclauss cclauss deleted the patch-1 branch April 16, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudep claudep claudep left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cclauss @manelclos @claudep @acdha