Django_v5.0 #1915
Django_v5.0 #1915
Conversation
haystack/fields.py
Outdated
| try: # datetime_safe was removed in Django 5.0 | ||
| from django.utils import datetime_safe | ||
| except ImportError: | ||
| import datetime as datetime_safe |
There was a problem hiding this comment.
Looking at how Django made this replacement in its own code in django/django@46346f8ea0802, it looks like it is always related to producing strftime ouptut, which is not the case in that file. So I would simply replace this by import datetime and replacing datetime_safe occurrences later in the file.
There was a problem hiding this comment.
It is always difficult to be confident about making changes to a project that is failing its CI. I have taken a lot of runs at fixing this project's GitHub Actions but cannot seem to find the magic combination.
I have been using this branch to get all pytests of my main project to pass...
Pipfile:
# django-haystack = "*" # Currently incompatible with Django 5.0
django-haystack = {git = "https://github.com/cclauss/django-haystack.git@Django_v5"}
but now that they are passing, let's try todo as you suggest above.
|
% I did not change these instances because https://pypi.org/project/Whoosh has not been updated since 2016 and points to a nonexistent BitBucket repo however https://github.com/mchaput/whoosh still exists. |
https://docs.djangoproject.com/en/5.0/releases/5.0/#features-removed-in-5-0
Any Django 5 projects that
import haystackwill fail without this change.