Skip to content

Adhered to field naming format setting when generating schema #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 6, 2022
Merged

Adhered to field naming format setting when generating schema #1048

merged 4 commits into from
Sep 6, 2022
PHP-Proxy

PHP-Proxy

Error accessing resource: 429 - Too Many Requests

Conversation

jokiefer
Copy link
Contributor

@jokiefer jokiefer commented Feb 6, 2022 •
edited by sliverc
Loading

Description of the Change

Added additional field name formatting which got missed out in PR #1003

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS
PHP-Proxy

PHP-Proxy

Error accessing resource: 404 - Not Found

@jokiefer jokiefer changed the title fixes attribute naming in filter backend and AutoSchema WIP: fixes attribute naming in filter backend and AutoSchema Feb 7, 2022
@jokiefer jokiefer changed the title WIP: fixes attribute naming in filter backend and AutoSchema fixes attribute naming in filter backend and AutoSchema Feb 7, 2022
sliverc
sliverc requested changes Feb 9, 2022
View reviewed changes
Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Could you please also add a test which adds those cases?

I guess easiest is to extend the AuthorViewSet so it covers the cases which are fixed in this PR. The tests in test_openapi.py use snapshots so once the view has all the different cases added the snapshot only needs to be updated (pytest --snapshot-update).

@sliverc
Copy link
Member

sliverc commented Apr 26, 2022

@jokiefer Wanted to follow up whether you are still interested in working on this PR?

@sliverc sliverc changed the title fixes attribute naming in filter backend and AutoSchema Adhered to field naming format setting when generating schema Sep 6, 2022
@sliverc
Copy link
Member

sliverc commented Sep 6, 2022

I had some time at hand and wanted to make sure that this PR lands in the next version (which is hopefully released soon, waiting for DRF to release a new version supporting Django 4.1). I added a test and made minor adjustments to the PR.

When adding the test, I noticed that there was actually an error in the code. It called format_field_names instead of format_field_name so this did not work. Once again, a great example of how important tests are.

Anyway. Thanks for bringing this up and working on it.

@sliverc sliverc merged commit 897305c into django-json-api:main Sep 6, 2022
@sliverc sliverc mentioned this pull request Sep 6, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sliverc sliverc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jokiefer @sliverc