Skip to content

Avoid error with related urls when retrieving relationship #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2018
Merged

Avoid error with related urls when retrieving relationship #517

merged 1 commit into from
Nov 16, 2018

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Nov 16, 2018

Fixes #489

Description of the Change

Fixes raising of error when retrieving relationship which is referenced as ForeignKeyon parent

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • changelog entry added to CHANGELOG.md
  • author name in AUTHORS

Avoid error with related urls when retrieving relationship
041bd7e 
Fixes raising of error when retrieving relationship is referenced
as `ForeignKey`on parent
@sliverc sliverc requested a review from n2ygk November 16, 2018 16:16
@sliverc sliverc mentioned this pull request Nov 16, 2018
Closed
5 tasks
n2ygk
n2ygk approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better than mine. Thanks.

@n2ygk n2ygk merged commit 8c075d0 into django-json-api:master Nov 16, 2018
@sliverc sliverc deleted the related_object_optimization branch November 16, 2018 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sliverc @n2ygk