Skip to content

allow working with custom ids #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 16, 2021
Merged

allow working with custom ids #182

merged 6 commits into from
Jan 16, 2021

Conversation

obayemi
Copy link
Contributor

@obayemi obayemi commented Oct 23, 2020

treebeard was expecting the primary key for models to be integer serials

fixed two problems

  1. detection of insertion was checking if the pk was None, but with custom ids with default values (as with uuids) the pk is never None as the default is set at model init. changed all checks to use more reliable model._state.adding instead.
  2. the forms forced the use of integer as reference id, so it triggered an error when sending an uuid. I used the model field's formfield to_python as coerce function if applicable.

I also added tests but let me know if I should add more tests.

@obayemi
Copy link
Contributor Author

obayemi commented Oct 23, 2020 •
edited
Loading

oh, I just noticed that was already mostly fixed by #93 ... Should i delete it ?
The only real difference is that I kept the TypedChoiceField and used the id fields's formfield as a coersion method and that I don't check for both instance pk and _state.adding

EDIT: also changed the "default id" assigned to the "root" element to None instead of 0 to be have a more consistent "Null-ish" value across different types

@obayemi
Copy link
Contributor Author

obayemi commented Oct 26, 2020

also set the "root" / reference node to None in the forms for a more reliable behaviour across different types.

@rhunwicks rhunwicks mentioned this pull request Jan 14, 2021
Merged
@johanneswilm johanneswilm mentioned this pull request Jan 15, 2021
Merged
@tabo tabo merged commit 6d1a77b into django-treebeard:master Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obayemi @tabo