Fix HTTP auth password encoding #302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Username/password encoding in HTTP basic auth is currently broken for non-ASCII password.
Example with user
user
and passwordunusual-char-é
. With curl it works as expected:But with couchdb-python the string is decoded from
utf-8
then re-encoded intolatin1
, causing an incorrect Authorization header:This patch fixes this wrong encoding charset by using
utf-8
(used by default by CouchDB) instead oflatin1
.Closes: #301