Skip to content

Conversation

geppettodivacin
Copy link
Contributor

Documentation can be found at
http://docs.couchdb.org/en/2.0.0/query-server/protocol.html

Previously, the server had been receiving indecipherable errors complaining about an unrecognized response and printing the entire traceback in repr() format. The new format properly either sends an error message back to the client or prints a log message to the console.

@djc
Copy link
Owner

djc commented May 29, 2017

My question here is about 1.x vs 2.x compatibility. CouchDB-Python must still support CouchDB-1.0. Is the logging part of the protocol the same in both of these versions, or did something change?

@geppettodivacin
Copy link
Contributor Author

As I have only used CouchDB for the last few weeks, I assumed that you had been using the correct syntax for 1.x. However, according to the docs, at least as far back as 1.5, it uses the list format for errors and logging.

http://docs.couchdb.org/en/1.6.0/query-server/protocol.html

http://docs.couchdb.org/en/1.5.0/query-server/protocol.html

@geppettodivacin
Copy link
Contributor Author

Is there anything I should change about this PR before it's merged in?

@djc djc merged commit e8eab1f into djc:master Jun 2, 2017
@djc
Copy link
Owner

djc commented Jun 2, 2017

Nope, I just needed a little time to review this again! Thanks!

@geppettodivacin geppettodivacin deleted the fixup-logging branch June 28, 2017 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants