Make Record serializable again #242
Conversation
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
============================================
+ Coverage 57.26% 57.29% +0.02%
+ Complexity 2088 2087 -1
============================================
Files 163 163
Lines 10907 10912 +5
Branches 1573 1575 +2
============================================
+ Hits 6246 6252 +6
+ Misses 4235 4234 -1
Partials 426 426
Continue to review full report at Codecov.
|
05e0f0a to
67923aa
Compare
Instead of relying on the unstable default Java serialization of each record type, this uses a proxy object. The proxy object only contains the DNS wire data of a record, which is guaranteed to be stable. This avoids all concerns about compatibility when Record classes evolve and with inheritance. Closes #132 See #114
67923aa to
06e2334
Compare
|
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
We are fortunate in this project that we happen to have a very battle tested serialisation format for our value objects :)
As an aside, I don't think that the serialisation support in java was ever very well thought out to begin with, but that is not the fault of this change. It is simply magic that adding a non-public non-overriding writeReplace() method changes the serialisation behaviour.
- Serializable updates for #242 - History on GitHub is not so important anymore, move it down - Update links to RFCs - Improve doc about the SPI
Instead of relying on the unstable default Java serialization of each
record type, this uses a proxy object. The proxy object only contains
the DNS wire data of a record, which is guaranteed to be stable. This
avoids all concerns about compatibility when Record classes evolve and
with inheritance.
Closes #132
See #114