Allow SVCB ServiceMode records without params #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed for ServiceMode records Add unit tests to verify that ServiceMode records without any params are allowed and can be properly converted between text and wire formats
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
=========================================
Coverage 57.26% 57.26%
+ Complexity 2088 2083 -5
=========================================
Files 163 163
Lines 10907 10905 -2
Branches 1573 1572 -1
=========================================
- Hits 6246 6245 -1
+ Misses 4235 4234 -1
Partials 426 426
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #243
Remove incorrect check that required at least one param to be specified for ServiceMode records
Add unit tests to verify that ServiceMode records without any params are allowed and can be properly converted between text and wire formats