Validation bug Fix: DocList and DocVec are not coerced to each other #1568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: agaraman0 <agaraman0@gmail.com>
|
Hello @agaraman0 , can u please handle the tests and mypy errors? |
samsja
reviewed
May 31, 2023
docarray/array/doc_list/doc_list.py
Outdated
Comment on lines
272
to
273
| elif isinstance(value, DocVec): | ||
| return value.to_doc_list() |
There was a problem hiding this comment.
here we need to test if the documen_type of the value and self are compatible.
If they are you can silence mypy by return cast(T, )
samsja
reviewed
May 31, 2023
docarray/array/doc_list/doc_list.py
Outdated
Comment on lines
272
to
273
| elif isinstance(value, DocVec): | ||
| return value.to_doc_list() |
There was a problem hiding this comment.
Suggested change
| elif isinstance(value, DocVec): | |
| return value.to_doc_list() | |
| elif isinstance(value, DocVec): | |
| if issubclass(value.doc_type, self.doc_type) or value.doc_type == cls.doc_type: | |
| return cast(T, value.to_doc_list() | |
| else: | |
| raise ValueError(f'DocList[value.doc_type] is not compatible with {cls}') |
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Signed-off-by: agaraman0 <agaraman0@gmail.com>
samsja
approved these changes
Jun 6, 2023
Signed-off-by: agaraman0 <agaraman0@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #1545