fix: update text search to match client's new sig #1654
Conversation
| @@ -52,7 +52,7 @@ hnswlib = {version = ">=0.6.2", optional = true } | |||
| lz4 = {version= ">=1.0.0", optional = true} | |||
| pydub = {version = "^0.25.1", optional = true } | |||
| pandas = {version = ">=1.1.0", optional = true } | |||
| weaviate-client = {version = ">=3.15", optional = true} | |||
| weaviate-client = {version = ">=3.17, <3.18", optional = true} | |||
There was a problem hiding this comment.
| weaviate-client = {version = ">=3.17, <3.18", optional = true} | |
| weaviate-client = {version = ">=3.17", optional = true} |
I think it is better to not cap it. It might be that 3.18 will not break anything for docarray
There was a problem hiding this comment.
@samsja we should cap it now as there are breaking changes in the weavaite implementation if we don't. I will make another PR to fix it and will remove the cap there.
There was a problem hiding this comment.
but this means that the next version of docarray will never be compatible with the next one of weaviate. We cannot know in advance that it will be the case. It is better to react after wards
There was a problem hiding this comment.
If I remove the cap now, then will poetry download the latest client i.e. 3.20.1 into the CI? If it does, then some of the tests will fail.
There was a problem hiding this comment.
the week after next week
There was a problem hiding this comment.
then lets merge like this for now. Sorry misunderstanding on my side I thought this PR was fixing docarray for version 3.17 and above
fix #1653