fix: avoid converting doclists in the base index #1685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
|
📝 Docs are deployed on https://ft-fix-dont-convert-doclist--jina-docs.netlify.app 🎉 |
JoanFM
approved these changes
Jul 5, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_dict_list_to_docarray expects a list of dictionaries which is then transformed into a DocList. However, since DocList extends List, the condition is true even if docs is already a DocList, which then leads to an error.
We already fixed this in one place but there are other parts too that need an extra check.
Found while working on milvus pr