This repository was archived by the owner on Feb 14, 2022. It is now read-only.
Bump Kubernetes vendoring to 1.16.2 #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1bb60ce to
698549f
Compare
chris-crone
commented
Oct 9, 2019
| @@ -81,7 +81,7 @@ func TestConvertTable(t *testing.T) { | |||
| { | |||
| name: "not a stack", | |||
| object: &metav1beta1.Table{}, | |||
| expectedError: "unexpected object type *v1beta1.Table", | |||
| expectedError: "unexpected object type *v1.Table", | |||
There was a problem hiding this comment.
Note to reviewer that this change was needed
glours
approved these changes
Oct 9, 2019
chris-crone
commented
Oct 10, 2019
| @@ -55,7 +55,7 @@ func setConfigDefaults(config *rest.Config) error { | |||
| gv := v1alpha3.SchemeGroupVersion | |||
| config.GroupVersion = &gv | |||
| config.APIPath = "/apis" | |||
| config.NegotiatedSerializer = serializer.DirectCodecFactory{CodecFactory: scheme.Codecs} | |||
| config.NegotiatedSerializer = serializer.WithoutConversionCodecFactory{CodecFactory: scheme.Codecs} | |||
There was a problem hiding this comment.
Note to reviewer: This change was based on this: kubernetes/kubernetes#76270
b66d6c2 to
1c80fc7
Compare
glours
approved these changes
Oct 16, 2019
|
We need the delete with forward policy to pass. It is a non-regression test related to a bug found in the UCP UI. |
f5706d1 to
f487653
Compare
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
+ Coverage 64.79% 65.02% +0.22%
==========================================
Files 90 90
Lines 10940 10958 +18
==========================================
+ Hits 7089 7125 +36
+ Misses 3550 3537 -13
+ Partials 301 296 -5
Continue to review full report at Codecov.
|
Primary action was bumping the Kubernetes vendoring, other operations were to make it work. * Kubernetes to 1.16.2 * Removed `bitbucket.org/ww/goautoneg` as it is now included in Prometheus * Changed `serializer.DirectCodecFactory` to `serializer.WithoutConversionCodecFactory` in `api/client/clientset/typed/compose/*/compose_client.go` * Moved grpc to v1.23.1 * Ran `dep ensure -update sigs.k8s.io/structured-merge-diff` * Ran `dep ensure -update k8s.io/utils` Signed-off-by: Christopher Crone <christopher.crone@docker.com>
This fixes docker#150. As the `Stack` struct does not support being serialized to protobuf, we must not advertise that we support protobuf. Signed-off-by: Christopher Crone <christopher.crone@docker.com>
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
68b8c8e to
eea9814
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional information:
Gopkg.tomlserializer.DirectCodecFactorytoserializer.WithoutConversionCodecFactoryinapi/client/clientset/typed/compose/*/compose_client.gointernal/registry/tableconvert_test.gobitbucket.org/ww/goautonegas it is now included in Prometheusdep ensure -update sigs.k8s.io/structured-merge-diffdep ensure -update k8s.io/utilsFixes #150 by not advertising protobuf support.