Skip to content

Fix NPE when file doesn't exist. #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2018
Merged

Conversation

KostyaSha
Copy link
Member

@KostyaSha KostyaSha commented Nov 27, 2018

Such use case existed before.
related to #727


This change is Reviewable

Such use case existed before.
related to docker-java#727
@KostyaSha
Copy link
Member Author

cc @fbuecklers

@codecov-io
Copy link

codecov-io commented Nov 27, 2018

Codecov Report

Merging #1138 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1138      +/-   ##
=========================================
+ Coverage   58.58%   58.6%   +0.02%     
=========================================
  Files         451     451              
  Lines        8885    8886       +1     
  Branches      543     543              
=========================================
+ Hits         5205    5208       +3     
+ Misses       3384    3383       -1     
+ Partials      296     295       -1
Impacted Files Coverage Δ
...github/dockerjava/core/exec/BuildImageCmdExec.java 57.89% <ø> (ø) ⬆️
...ithub/dockerjava/core/exec/AbstrDockerCmdExec.java 71.87% <ø> (ø) ⬆️
...a/com/github/dockerjava/core/DockerConfigFile.java 59.18% <100%> (ø) ⬆️
...hub/dockerjava/core/DefaultDockerClientConfig.java 83.03% <100%> (ø) ⬆️
.../github/dockerjava/core/exec/PullImageCmdExec.java 83.33% <100%> (+1.51%) ⬆️
...va/org/apache/http/impl/io/ChunkedInputStream.java 59.04% <0%> (+1.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c553f1...289fb1e. Read the comment docs.

@KostyaSha KostyaSha added this to the 3.1.0-rc-7 milestone Nov 27, 2018
@KostyaSha KostyaSha merged commit 31281e8 into docker-java:master Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants