Skip to content

! [api/healthcheck] startPeriod is now a long #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2019
Merged

! [api/healthcheck] startPeriod is now a long #1152

merged 1 commit into from
Jan 21, 2019

Conversation

Grisu118
Copy link
Contributor

@Grisu118 Grisu118 commented Jan 21, 2019 •
edited by marcuslinke
Loading

As it is saved in nanoseconds, int is to small to save sensible values

PR as requested in #1143

This change is Reviewable

@Grisu118
! [api/healthcheck] startPeriod is now a long
a2df1fc 
As it is saved in nanoseconds, int is to small to save sensible values
@KostyaSha
Copy link
Member

Does it fix issue?

@Grisu118
Copy link
Contributor Author

Yes, it fixes the issue.

After I remembered the application with the problem, I tested with the released version (3.1.0) which fails and with the fixed one.

@KostyaSha KostyaSha added this to the 3.1.1 milestone Jan 21, 2019
@KostyaSha KostyaSha merged commit 660ee6e into docker-java:master Jan 21, 2019
@Grisu118 Grisu118 deleted the fix-parse-error branch January 21, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Grisu118 @KostyaSha