Skip to content

Add unit tests for netty.handler.FramedResponseStreamHandler #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2019

Conversation

JohnLBergqvist
Copy link
Contributor

@JohnLBergqvist JohnLBergqvist commented Feb 19, 2019

Hi,

I've analysed your code base and noticed some gaps in the coverage of com.github.dockerjava.netty.handler.FramedResponseStreamHandler.

I've written some tests for the functions in this class with the help of Diffblue Cover.

Hopefully these tests should help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be more than happy to look at a particular class and you help achieve a higher coverage figure.


This change is Reviewable

These tests were written with the aid of Diffblue Cover.
@KostyaSha KostyaSha added this to the 3.1.2 milestone Mar 9, 2019
@KostyaSha KostyaSha merged commit 4c6ab0e into docker-java:master Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants