Skip to content

Use JDK Objects requireNonNull over Guava checkNotNull #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 30, 2023
Merged

Use JDK Objects requireNonNull over Guava checkNotNull #1981

merged 3 commits into from
Mar 30, 2023

Conversation

belugabehr
Copy link
Contributor

Remove dependency on Google Guava library in favor of JDK APIs.

@Lewik Lewik mentioned this pull request Nov 18, 2022
Open
@eddumelendez eddumelendez self-requested a review November 30, 2022 15:44
@belugabehr
Copy link
Contributor Author

@eddumelendez Are you able to take a look at this?

Thanks.

@eddumelendez
Copy link
Member

@belugabehr the dependency was not dropped in order to avoid breaking changes?

@belugabehr
Copy link
Contributor Author

@eddumelendez This PR is not meant to remove all of Guava. This is just removing one piece. There will need to be additional work to remove it all.

@eddumelendez eddumelendez requested a review from a team as a code owner March 9, 2023 00:04
@eddumelendez eddumelendez added this to the next milestone Mar 30, 2023
@eddumelendez eddumelendez merged commit 97579e5 into docker-java:main Mar 30, 2023
@eddumelendez
Copy link
Member

Thanks for your contrbution, @belugabehr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddumelendez eddumelendez eddumelendez approved these changes

Assignees
No one assigned
Labels
type/housekeeping
Projects
None yet
Milestone
3.3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@belugabehr @eddumelendez