Don't swallow IOException caused by opening socket #2041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
564c7d3 to
2e91373
Compare
2e91373 to
d82d9be
Compare
|
Bump |
1 similar comment
|
Bump |
|
@eddumelendez Would you be able to check this out? |
|
Bump |
a36141d to
4d24f18
Compare
Merged
|
Bump |
f2b77b8 to
9d8db99
Compare
|
Rebased |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Rebased, can we get this merged @eddumelendez? |
|
Thanks for your contribution, @Sineaggi ! |
svc-squareup-copybara
pushed a commit
to cashapp/misk
that referenced
this pull request
Dec 12, 2024
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.http-client:google-http-client-jackson2](https://github.com/googleapis/google-http-java-client) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.45.2` -> `1.45.3` | | [com.google.http-client:google-http-client](https://github.com/googleapis/google-http-java-client) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.45.2` -> `1.45.3` | | [com.google.auth:google-auth-library-oauth2-http](https://github.com/googleapis/google-auth-library-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.30.0` -> `1.30.1` | | [com.google.auth:google-auth-library-credentials](https://github.com/googleapis/google-auth-library-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.30.0` -> `1.30.1` | | [org.flywaydb:flyway-gradle-plugin](https://flywaydb.org) ([source](https://github.com/flyway/flyway)) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `11.0.1` -> `11.1.0` | | [com.github.docker-java:docker-java-transport](https://github.com/docker-java/docker-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `3.4.0` -> `3.4.1` | | [com.github.docker-java:docker-java-transport-httpclient5](https://github.com/docker-java/docker-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `3.4.0` -> `3.4.1` | | [com.github.docker-java:docker-java-core](https://github.com/docker-java/docker-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `3.4.0` -> `3.4.1` | | [com.github.docker-java:docker-java-api](https://github.com/docker-java/docker-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `3.4.0` -> `3.4.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.31` -> `2.29.32` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.31` -> `2.29.32` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.31` -> `2.29.32` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.31` -> `2.29.32` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.31` -> `2.29.32` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.31` -> `2.29.32` | --- >⚠️ **Warning** > > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleapis/google-http-java-client (com.google.http-client:google-http-client-jackson2)</summary> ### [`v1.45.3`](https://github.com/googleapis/google-http-java-client/blob/HEAD/CHANGELOG.md#1453-2024-12-11) ##### Dependencies - Update dependency io.grpc:grpc-context to v1.69.0 ([#​2050](googleapis/google-http-java-client#2050)) ([9f4f6ab](googleapis/google-http-java-client@9f4f6ab)) - Update github/codeql-action action to v3.27.7 ([#​2049](googleapis/google-http-java-client#2049)) ([9190382](googleapis/google-http-java-client@9190382)) </details> <details> <summary>googleapis/google-auth-library-java (com.google.auth:google-auth-library-oauth2-http)</summary> ### [`v1.30.1`](https://github.com/googleapis/google-auth-library-java/blob/HEAD/CHANGELOG.md#1301-2024-12-11) ##### Bug Fixes - JSON parsing of S2A addresses. ([#​1589](googleapis/google-auth-library-java#1589)) ([9d5ebfe](googleapis/google-auth-library-java@9d5ebfe)) </details> <details> <summary>docker-java/docker-java (com.github.docker-java:docker-java-transport)</summary> ### [`v3.4.1`](https://github.com/docker-java/docker-java/releases/tag/3.4.1) [Compare Source](docker-java/docker-java@3.4.0...3.4.1) ##### Changes - Fix restart test [@​eddumelendez](https://github.com/eddumelendez) ([#​2375](docker-java/docker-java#2375)) ##### 📈 Enhancements - Add support for CgroupVersion and CgroupDriver [@​LarsSven](https://github.com/LarsSven) ([#​2360](docker-java/docker-java#2360)) ##### 🧰 Maintenance - Don't swallow IOException caused by opening socket [@​Sineaggi](https://github.com/Sineaggi) ([#​2041](docker-java/docker-java#2041)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 6eb3a8d6c07d3090499286e2624f648323e96355
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging an issue locally I noticed the stacktrace included references to the
DomainSocketclass. This meant that somehowjava.net.UnixDomainSocketAddresswas being bypassed. I thought there was an issue with the jvm I was running on, but it turns out we were simply swallowing the IOException thrown by theSocketChannel.open(this.socketAddress);call, then trying to load the socket via the DomainSocket class.I've fixed the code by adding the thrown methods to the signature, and catching the exact exceptions thrown by the methods in the class one level higher.
Exception in question.