Skip to content

fix(2127): handle repoNames with tags #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

setchy
Copy link
Contributor

@setchy setchy commented Jun 2, 2023

This update improved the handling for resolveRepositoryName when the image statement includes a registry and tags.

Current behavior will throw the error as reported in the issue

Resolves: #2127 - confirmed by @leomao10

@setchy setchy requested a review from a team as a code owner June 2, 2023 20:55
@setchy
Copy link
Contributor Author

setchy commented Jun 19, 2023

@eddumelendez - could you kindly review this PR 🙏

Copy link
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eddumelendez eddumelendez merged commit dd0de7c into docker-java:main Jun 19, 2023
@eddumelendez
Copy link
Member

Thanks for your contribution, @setchy !

@eddumelendez eddumelendez added this to the next milestone Jun 19, 2023
@setchy
Copy link
Contributor Author

setchy commented Jun 19, 2023

Thanks @eddumelendez for the speedy review. Greatly appreciated 🙏

@setchy
Copy link
Contributor Author

setchy commented Jun 20, 2023

@eddumelendez - to help with my internal sprint planning and stakeholder mgmt, can you educate my about the release cadence for docker-java

@eddumelendez
Copy link
Member

There is no release schedule but as soon there are many good improvement features we will do the release. Indeed, I'm just waiting for other PR to perform it.

@setchy setchy deleted the feature/2127-support-tag-and-digest-2 branch July 5, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse Docker images of <name>:<tag>@sha256:<hash> format
2 participants