updated bouncy castle to bcpkix-jdk18on:1.75 and fix missing reflect config for graalvm #2135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddumelendez
approved these changes
Jul 7, 2023
|
Thanks for your contribution, @cmdjulian ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #2125, the bouncy castle version is rather old. As the target is already set to
1.8, we can update bouncy castle to the newest version.There is a other motivation behind it. Using
bcpkix-jdk15ontogether with graalvm results in numerous errors, as the old bouncy castle version is not properly detected by graal and therefore not registered as an security provider, which leads to missing reflection configs while running.This is also fixed by using
bcpkix-jdk18on.