Remove exclusion and fix httpclient5 compatibility #2294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
847b3b1 to
98d30c3
Compare
98d30c3 to
3860ea8
Compare
|
Rebased, all checks are green. |
Can you elaborate more on this, please? |
|
@eddumelendez According to the maintainers of apache http, |
|
Thanks @twarner-sofi ! useful info 👍🏽 |
eddumelendez
approved these changes
Feb 26, 2024
|
Thanks for your contribution, @Sineaggi ! |
This was referenced Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the exclusion as-is, newer versions of apache httpclient fail with ClassNotFoundError.
The main fix here is to avoid subclassing the PlainConnectionSocketFactory, and instead implement the ConnectionSocketFactory interfact directly, delegating to PlainConnectionSocketFactory.INSTANCE where necessary.
Fixes #2290