Support Dockerfile-Specific Dockerigore Files #2441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhealio
reviewed
May 19, 2025
| if (dockerFileSpecificIgnoreFile.exists()) { | ||
| return dockerFileSpecificIgnoreFile; | ||
| } else { | ||
| return new File(dockerFileDirectory, ".dockerignore"); |
There was a problem hiding this comment.
Shouldn't it be falling back to the .dockerignore in the root directory of the context? If so, the test(s) may need to be updated to reflect this behavior.
Suggested change
| return new File(dockerFileDirectory, ".dockerignore"); | |
| return new File(baseDirectory, ".dockerignore"); |
There was a problem hiding this comment.
I implemented your suggestion and added a test for falling back to the default .dockerignore. The tests that existed before this pull request already relied on the fall back behavior.
…-files' into dockerfile-specific-dockerignore-files # Conflicts: # docker-java-core/src/main/java/com/github/dockerjava/core/dockerfile/Dockerfile.java # docker-java/src/test/java/com/github/dockerjava/core/dockerfile/DockerfileAddMultipleFilesTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Dockerfile-Specific .dockerignore files per the Docker Manual.