Skip to content

Fix default docker-java.properties to match with docker CLI defaults #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2016
Merged

Fix default docker-java.properties to match with docker CLI defaults #590

merged 1 commit into from
Jun 3, 2016

Conversation

marcuslinke
Copy link
Contributor

@marcuslinke marcuslinke commented Jun 2, 2016 •
edited
Loading

This change is Reviewable

KostyaSha
KostyaSha reviewed Jun 2, 2016
View reviewed changes
src/main/resources/META-INF/services/com.github.dockerjava.api.command.DockerCmdExecFactory
@@ -1 +0,0 @@
com.github.dockerjava.jaxrs.DockerCmdExecFactoryImpl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KostyaSha
Copy link
Member

LGTM.
I would be happy if you also fix somehow ability to clientbuild settings wihout path to certs (i create sslcontext programmatically)

@marcuslinke marcuslinke merged commit 0381dde into master Jun 3, 2016
@marcuslinke marcuslinke changed the title Fix issue #480 Fix default docker.properties to match with docker CLI defaults Jun 3, 2016
This was referenced Jun 3, 2016
Closed
Closed
@francisdb
Copy link

👍

@marcuslinke marcuslinke changed the title Fix default docker.properties to match with docker CLI defaults Fix default docker-java.properties to match with docker CLI defaults Jun 3, 2016
@KostyaSha KostyaSha deleted the issue-480 branch June 28, 2016 19:09
panuse pushed a commit to TuKangTech/docker-java that referenced this pull request Aug 20, 2017
@marcuslinke
Merge pull request docker-java#590 from docker-java/issue-480
9747663 
Fix issue docker-java#480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcuslinke @KostyaSha @francisdb