Skip to content

Fix for #687 #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2016
Merged

Fix for #687 #689

merged 1 commit into from
Aug 30, 2016

Conversation

tejksat
Copy link
Contributor

@tejksat tejksat commented Aug 30, 2016 •
edited by marcuslinke
Loading

This change is Reviewable

@KostyaSha
Copy link
Member

So what was the reason?

@tejksat
Copy link
Contributor Author

tejksat commented Aug 30, 2016

@KostyaSha actually I'm not sure that these changes fix the problem.. I will take a look tomorrow.

@KostyaSha
Copy link
Member

I can merge it and it will be clear on the next PR builds. In any case it fails now.

@tejksat
Copy link
Contributor Author

tejksat commented Aug 30, 2016

Fine! Sounds reasonable :)

@KostyaSha KostyaSha merged commit 5a0c696 into docker-java:master Aug 30, 2016
@tejksat tejksat deleted the fixHelloWorldHeisentest branch September 5, 2016 15:48
panuse pushed a commit to TuKangTech/docker-java that referenced this pull request Aug 20, 2017
@KostyaSha
Merge pull request docker-java#689 from tejksat/fixHelloWorldHeisentest
d900537 
Fix for docker-java#687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type/housekeeping
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tejksat @KostyaSha