Swarm branch, picking other prs #796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply changes from review Remove unused import Fix compile errors
|
@Yogu what PRs are correct? I see Swarm and SwarmNode class naming |
Add ListNodes implementation Fix error in ListNodesCmdExec Add FilterBuilder for swarmNodes, renamed Node to SwarmNode Update model classes for SwarmNodes add implementation for update,list,remove and inspect of a swarmNode Update model classes for docker-swarm-node Add methods for swarmNode to execFactories
Fix service tests Add missing withDriver() method Fix json name of Networks in ServiceSpec Add tests to add network to services Do not fail on empty beans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can't squash merge because it will lost gh contribution for people
This change is