Make NettyDockerCmdExecFactory has compatibility both Linux and OSX automatically #862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #862 +/- ##
==========================================
- Coverage 71.9% 71.77% -0.13%
==========================================
Files 306 306
Lines 6858 6869 +11
Branches 509 511 +2
==========================================
- Hits 4931 4930 -1
- Misses 1634 1644 +10
- Partials 293 295 +2
Continue to review full report at Codecov.
|
cb51433 to
b0428cf
Compare
marcuslinke
reviewed
Jun 14, 2017
pom.xml
Outdated
| <artifactId>netty-transport-native-kqueue</artifactId> | ||
| <version>${netty.version}</version> | ||
| <classifier>osx-x86_64</classifier> | ||
| <exclusions> |
There was a problem hiding this comment.
Why is this exclusion?
There was a problem hiding this comment.
Oh, I will remove this exclusion later
|
For discussion: As netty/netty#6837 wont be fixed by the netty team this PR will work with MacOS Sierra+ only. Not sure if this is a blocker as the JAXRS implementation doesn't have this limitation. |
|
@xuchenCN please squash commits |
821b8c9 to
7e1532f
Compare
|
Hi @KostyaSha sorry for late, already squashed commits. Thx |
panuse
pushed a commit
to TuKangTech/docker-java
that referenced
this pull request
Aug 20, 2017
Make NettyDockerCmdExecFactory has compatibility both Linux and OSX automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make compatibility both Linux and OSX and automatically setting the EventLoopGroup (EpollEventLoopGroup or KQueueEventLoopGroup) .
Due to netty/netty#6837 this PR only work on OSX 10.12
Inspired by @marcuslinke 's branch netty-native-kqueue and we discussion #859 .
This change is