Fix .dockerignore handling on Windows #893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@orzeh @KostyaSha should we spin off another PR/branch to get this merged into the next point release (3.0.13)? |
|
Is it possible to cover with some test case? |
|
@KostyaSha existing test fails on Windows without this fix. |
|
@orzeh @KostyaSha one these days, hopefully in the not too distant future, we'll all look back and laugh that folks were ever using windows in the first place ;) |
|
Could you place comment about windows in code? |
|
@KostyaSha where? And what should I comment? |
|
Under this line describing that this required for windows |
|
@KostyaSha ok, I added comment. |
|
and to 3.0.x if needed faster |
panuse
pushed a commit
to TuKangTech/docker-java
that referenced
this pull request
Aug 20, 2017
Fix .dockerignore handling on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When excluding files from build context using patterns defined in
.dockerignorefileFilePathUtil.relativize()method is used. It changes path separator to/which leads to files not being properly excluded on Windows machines. This PR fixes that issue.This PR is partially related to #890 and gradle-docker-java plugin issue as it is impossible to exclude subdirectories and/or files on Windows.
This change is