Add Privileged property to ExecCreateCmd #903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.0.x #903 +/- ##
==========================================
+ Coverage 71.72% 71.73% +0.01%
==========================================
Files 306 306
Lines 6878 6881 +3
Branches 516 516
==========================================
+ Hits 4933 4936 +3
- Misses 1646 1647 +1
+ Partials 299 298 -1
Continue to review full report at Codecov.
|
KostyaSha
reviewed
Aug 18, 2017
| @@ -26,6 +26,9 @@ | |||
| @JsonProperty("Tty") | |||
| private Boolean tty; | |||
|
|
|||
| @JsonProperty("Privileged") | |||
| private Boolean isPrivileged; | |||
KostyaSha
reviewed
Aug 18, 2017
| @@ -109,6 +118,11 @@ public Boolean hasTtyEnabled() { | |||
| } | |||
|
|
|||
| @Override | |||
| public Boolean isPrivileged() { | |||
There was a problem hiding this comment.
for objects it should be getPrivileged() because Boolean is object
|
@KostyaSha I have updated the PR accordingly |
KostyaSha
reviewed
Sep 6, 2017
| @@ -26,6 +26,9 @@ | |||
| @JsonProperty("Tty") | |||
| private Boolean tty; | |||
|
|
|||
| @JsonProperty("Privileged") | |||
| private Boolean privileged; | |||
There was a problem hiding this comment.
please add
/**
* @since 1.29
**/
if it was added since 1.29..
|
@KostyaSha I added the since annotation. Sorry that it took so long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #902
This change is