Skip to content

INFRA Add getPid to InspectExecCmd #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2017
Merged

Conversation

albestia
Copy link

@albestia albestia commented Sep 30, 2017

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Sep 30, 2017

Codecov Report

Merging #928 into 3.0.x will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            3.0.x     #928      +/-   ##
==========================================
+ Coverage   71.75%   71.76%   +0.01%     
==========================================
  Files         306      306              
  Lines        6878     6879       +1     
  Branches      516      516              
==========================================
+ Hits         4935     4937       +2     
  Misses       1645     1645              
+ Partials      298      297       -1
Impacted Files Coverage Δ
...ub/dockerjava/api/command/InspectExecResponse.java 82.6% <100%> (+0.79%) ⬆️
...va/org/apache/http/impl/io/ChunkedInputStream.java 61.32% <0%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 943cc6f...5a0ea17. Read the comment docs.

@albestia
Copy link
Author

albestia commented Oct 5, 2017

Is there anything wrong with this PR? May I help somehow for you to merge it?

Thanks in advance.

@KostyaSha
Copy link
Member

Could you update integration test with checking this field?

@KostyaSha KostyaSha added this to the 3.0.15 milestone Oct 22, 2017
@KostyaSha KostyaSha merged commit a9f9838 into docker-java:3.0.x Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants