Set PGDATA permissions to 700 #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any feedback on this PR? |
| @@ -8,6 +8,7 @@ set_listen_addresses() { | |||
|
|
|||
| if [ "$1" = 'postgres' ]; then | |||
| mkdir -p "$PGDATA" | |||
| chmod -R 700 "$PGDATA" | |||
There was a problem hiding this comment.
Does everything in the directory need to be 700 as well or should we drop the -R?
|
Thanks for the reminder! |
|
LGTM, ping @tianon |
|
LGTM |
|
Great! Now to get this actually pushed to hub.docker.com, I'll need to update https://github.com/docker-library/official-images/blob/master/library/postgres, correct? Should I set them all to 4774c03af4eabffe5646a979f102ece292111b96 or is there any reason the tags use different git commits? |
|
That file's contents are generated via the "generate-stackbrew-library.sh"
script from this repo. 👍
|
|
Awesome, thanks for the direction! Created docker-library/official-images#1319. |
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Jan 7, 2016
- `docker`: alpine:3.3 (docker-library/docker#7) - `drupal`: 8.0.2 - `java`: explicit `JAVA_HOME` (docker-library/openjdk#61) - `php`: 5.5.31, 5.6.17, 7.0.2; fix edge case in `docker-php-ext-enable` (docker-library/php#172) - `postgres`: 9.5.0; set `PGDATA` perms to `0700` (docker-library/postgres#110) - `python`: add `alpine` variant for 3.5 (docker-library/python#74) - `rabbitmq`: fix SSL bugs (docker-library/rabbitmq#55, docker-library/rabbitmq#56) - `wordpress`: 4.4.1
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
- `docker`: alpine:3.3 (docker-library/docker#7) - `drupal`: 8.0.2 - `java`: explicit `JAVA_HOME` (docker-library/openjdk#61) - `php`: 5.5.31, 5.6.17, 7.0.2; fix edge case in `docker-php-ext-enable` (docker-library/php#172) - `postgres`: 9.5.0; set `PGDATA` perms to `0700` (docker-library/postgres#110) - `python`: add `alpine` variant for 3.5 (docker-library/python#74) - `rabbitmq`: fix SSL bugs (docker-library/rabbitmq#55, docker-library/rabbitmq#56) - `wordpress`: 4.4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mounting a volume to PGDATA, it may not have permissions set to 700 which causes postgres to fail with:
To fix this, we can explicitly set it to 700 like we do with the owner.