Export docker_process_sql for availability in executed initdb bash
#1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, executed bash initdb scripts do not need to source the entrypoint script (nor hardcode its path) to be able to use the function. Note that the export only works for executed _bash_ scripts.
23b3683 to
7a362b6
Compare
|
👀 Lines 166 to 174 in f85674c (If you remove the excitability bit on your initdb scripts, they'll be sourced instead and have direct access.) |
I know, but the executability check is unreliable, and doing that causes other problems: #1108 A reliable workaround against that is to make all .sh scripts executable, which then leads to this issue. Could you reconsider reopening/applying this? |
|
If you need to work around #1108 too, I'd suggest something like this: if ! command -v docker_process_sql > /dev/null; then
source /usr/local/bin/docker-entrypoint.sh
fi
...(the script is officially intended to be sourced in this way, and that is the canonical supported path for doing so) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, executed bash initdb scripts do not need to source the entrypoint script (nor hardcode its path) to be able to use the function.
Note that the export only works for executed bash scripts.
Not crucial by any means, but I think it'd be nice to have.
Could apply to < 16 entrypoints too, if this is seen desirable.