Fixes #105: Update configuration to allow additional settings to be loaded #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion This allows the default settings file to be supplemented with additional settings. It is possible to replace all settings in this way, so a complete configuration file can be used. This needs to be tested.
This allows the default settings file to be supplemented with additional settings. It is possible to replace all settings in this way, so a complete configuration file can be used. This needs to be tested.
|
@matthewfranglen why not using |
|
That would be within the The relevant error is: So the folder must be completely empty. |
|
Following @matthewfranglen's line of thought, why not include_dir '/etc/postgres/conf.d'? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows additional settings to be loaded from
/etc/postgres/postgresql.confas part of the docker command which launches any container based on 9.5, 9.4, 9.3 or 9.2. This file is optional.PostgreSQL version 9.1 and 9.0 do not support
include_if_existsso they have not been updated. It may be possible to add this feature to them by providing a blank file which can be replaced.I have tested that the databases created by these docker containers launch, perform simple queries, and have settings which can be updated by loading files.
I was able to load a change with the following command:
docker run docker run [OPTIONS] -v [FILE]:/etc/postgres/postgresql.conf [IMAGE DETAILS]I tested it by increasing the work_mem setting.