Skip to content

Listen on "local" interfaces during init #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2016

Conversation

tianon
Copy link
Member

@tianon tianon commented Mar 18, 2016

Fixes #129

http://www.postgresql.org/docs/9.1/static/runtime-config-connection.html

The default value is localhost, which allows only local TCP/IP "loopback" connections to be made.

This allows for crappy broken drivers that don't support Unix sockets to be usable during initdb.

@yosifkit
Copy link
Member

LGTM

yosifkit added a commit that referenced this pull request Mar 18, 2016
Listen on "local" interfaces during init
@yosifkit yosifkit merged commit dccb05d into docker-library:master Mar 18, 2016
@yosifkit yosifkit deleted the init-localhost branch March 18, 2016 21:41
tianon added a commit to infosiftr/stackbrew that referenced this pull request Apr 4, 2016
- `django`: 1.9.5
- `docker`: 1.11.0-rc3, add tune2fs and mkfs.xfs (docker-library/docker#10)
- `elasticsearch`: 2.3.1
- `golang`: force-enable `-fno-PIC` in Alpine (docker-library/golang#91)
- `irssi`: 0.8.19 (jessfraz/irssi#6), add Alpine variant (jessfraz/irssi#7)
- `java`: 9~b112-2 (still fails to build), Alpine to 8.77.03-r0 (8u77), fix Alpine tags to reference the proper version
- `julia`: 0.4.5
- `mariadb`: 10.1.13+maria-1~jessie
- `mongo`: 3.0.11
- `mysql`: `ENTRYPOINT` consistency (`docker-entrypoint.sh` with a compatibility symlink)
- `owncloud`: add `exif` module (docker-library/owncloud#53)
- `php`: 7.0.5, 5.6.20, 5.5.34, always enable `mbstring` (docker-library/php#211)
- `postgres`: 9.5.2-1.pgdg80+1, 9.4.7-1.pgdg80+1, 9.3.12-1.pgdg80+1, 9.2.16-1.pgdg80+1, 9.1.21-1.pgdg80+1, local interfaces during init (docker-library/postgres#136)
- `pypy`: 5.0.1
- `python`: fix `python-config` symlink (docker-library/python#99)
- `rocket.chat`: 0.24.0
- `ruby`: 2.1.9, switch `libedit` to `readline` for `irb` (docker-library/ruby#76)
@iamKurt
Copy link

iamKurt commented Apr 8, 2016

Does this mean that we have to copy libraries (and their dependencies) into the docker-entrypoint-initdb.d directory in order to take advantage of this?

@yosifkit
Copy link
Member

yosifkit commented Apr 8, 2016

@formerlyKurt, that or embed them elsewhere in the container at start time. Or you could make a new image FROM postgres that installs needed libraries.

@iamKurt
Copy link

iamKurt commented May 24, 2016

Interestingly, running liquibase from a shell script inside the /docker-entrypoint-initdb.d/ directory causes an error message:

db_1      | ERROR:  relation "public.databasechangeloglock" does not exist at character 22
db_1      | STATEMENT:  select count(*) from public.databasechangeloglock
db_1      | Liquibase Update Successful

It says that Liquibase succeeds but an error message with the word "lock" in it kinda freaks me out a little.

Here's the liquibase command that is being run:

/docker-entrypoint-initdb.d/utils/liquibase-3.4.2-bin/liquibase \
    --changeLogFile=/docker-entrypoint-initdb.d/utils/changelog/changelog.xml \
    --url="jdbc:postgresql://localhost/dev?stringtype=unspecified" \
    --username=postgres \
    --password=postgres \
    migrate

RichardScothern pushed a commit to RichardScothern/official-images that referenced this pull request Jun 14, 2016
- `django`: 1.9.5
- `docker`: 1.11.0-rc3, add tune2fs and mkfs.xfs (docker-library/docker#10)
- `elasticsearch`: 2.3.1
- `golang`: force-enable `-fno-PIC` in Alpine (docker-library/golang#91)
- `irssi`: 0.8.19 (jessfraz/irssi#6), add Alpine variant (jessfraz/irssi#7)
- `java`: 9~b112-2 (still fails to build), Alpine to 8.77.03-r0 (8u77), fix Alpine tags to reference the proper version
- `julia`: 0.4.5
- `mariadb`: 10.1.13+maria-1~jessie
- `mongo`: 3.0.11
- `mysql`: `ENTRYPOINT` consistency (`docker-entrypoint.sh` with a compatibility symlink)
- `owncloud`: add `exif` module (docker-library/owncloud#53)
- `php`: 7.0.5, 5.6.20, 5.5.34, always enable `mbstring` (docker-library/php#211)
- `postgres`: 9.5.2-1.pgdg80+1, 9.4.7-1.pgdg80+1, 9.3.12-1.pgdg80+1, 9.2.16-1.pgdg80+1, 9.1.21-1.pgdg80+1, local interfaces during init (docker-library/postgres#136)
- `pypy`: 5.0.1
- `python`: fix `python-config` symlink (docker-library/python#99)
- `rocket.chat`: 0.24.0
- `ruby`: 2.1.9, switch `libedit` to `readline` for `irb` (docker-library/ruby#76)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants