-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add ossp uuid to the alpine 9.2 and 9.3 images #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I just realized that both of these points only apply to version 9.3. What's the correct approach (I'm thinking about the template) to use the ossp-uuid lib on 9.3 and |
Can you elaborate on what the benefits of doing this might be? This isn't something that's done for the Debian packages (https://sources.debian.net/src/postgresql-9.6/9.6.1-2/debian/rules/#L74), which is where our |
This is only for version 9.3. The uuid-ossp extension isn't installed on the 9.4-alpine:
9.3-alpine:
The flag |
Ah! Grabbing http://apt.postgresql.org/pub/repos/apt/pool/main/p/postgresql-9.3/postgresql-9.3_9.3.15-1.pgdg80%2b1.debian.tar.xz and looking at --mandir=/usr/share/postgresql/$(MAJOR_VER)/man \
--docdir=/usr/share/doc/postgresql-doc-$(MAJOR_VER) \
--sysconfdir=/etc/postgresql-common \
--datarootdir=/usr/share/ \
--datadir=/usr/share/postgresql/$(MAJOR_VER) \
--bindir=/usr/lib/postgresql/$(MAJOR_VER)/bin \
--libdir=/usr/lib/$(DEB_HOST_MULTIARCH)/ \
--libexecdir=/usr/lib/postgresql/ \
--includedir=/usr/include/postgresql/ \
--enable-nls \
--enable-integer-datetimes \
--enable-thread-safety \
--enable-debug \
--disable-rpath \
--with-ossp-uuid \
--with-gnu-ld \
--with-pgport=5432 \
--with-system-tzdata=/usr/share/zoneinfo \ And over in
|
Alpine digging leads to https://bugs.alpinelinux.org/issues/4832, http://git.alpinelinux.org/cgit/aports/commit/?id=13925b3651ff86ea00c3864814eb83e0fb0862b3, and https://patchwork.alpinelinux.org/patch/933/, none of which really help shrink this 9.3-specific delta any. 😞 |
Technically, |
Clicked on the wrong button. 😑 |
It actually also applies to 9.2. |
I modified the update script to add |
We're running a custom 9.3-alpine image because of this issue, it would be nice if we could drop it and just use the official one. 🙂 |
Thanks for your patience -- I rebased and added a minor commit, and I suppose this will do for now (sad that we can't remove the disparity until Oct 2018 when 9.3 is EOL, but oh well). 👍 ❤️ |
(Will merge as soon as Travis is green as one final smoke test) |
- `postgres`: add OSSP uuid to 9.2 and 9.3 Alpine images (docker-library/postgres#255)
The 9.3 alpine image builds postgres with all the extensions (
make install-world
) but it's missing--with-ossp-uuid
.Just adding it is not enough because it seems like
uuid.h
fromutil-linux-dev
doesn't satisfy the check forlibuuid
, it's looking foruuid_export
which isn't present in that version ofuuid.h
.Because of this, I added ossp-uuid to the image. I had to use a mirror because the official ftp server is not reliable (it often fails with
CONNECTION_REFUSED
).It also doesn't increase the size of the image significantly (+0.2 MB).
I also removed 2 of the configure flags since they're not recognized :