Skip to content

Improve arbitrary user run on OpenShift #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mcanevet
Copy link

With this patch, the image is compatible with OpenShift as it will
generate a valid /etc/passwd at runtime for initdb.

With this patch, the image is compatible with OpenShift as it will
generate a valid /etc/passwd at runtime for initdb.
@tianon
Copy link
Member

tianon commented Jan 22, 2018

I'm definitely not comfortable with this image modifying /etc/passwd at runtime, that's a bit nasty. 😞

What is it about how OpenShift runs the image that makes this necessary?

@mcanevet
Copy link
Author

@tianon By default, OpenShift Container Platform runs containers using an arbitrarily assigned user ID. (see https://docs.openshift.com/container-platform/3.7/creating_images/guidelines.html chapter Support Arbitrary User IDs). This image mostly support it, but, as per the documentation, initdb needs the user to exist in /etc/passwd. Both proposed workaround are not very easy to setup in a production orchestrator. With this patch, I think this image will fully support to be run with an arbitrary user and would not require extra setup for that anymore.

@mcanevet
Copy link
Author

mcanevet commented Jun 1, 2018

@tianon could you please explain what is the problem with this PR except that you are not "comfortable" with modifying the /etc/passwd at runtime? Unless I'm wrong, it does not add a security hole.
This will make this image fully support running as arbitrary use (and not "mostly" as now).

@yosifkit
Copy link
Member

yosifkit commented Jun 1, 2018

No need for editable /etc/passwd. Fixed by #448.

@yosifkit yosifkit closed this Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants