Check that vol actually contains DB files, as opposed to a non-empty dir. #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dir. Referencing file list here: http://www.postgresql.org/docs/9.1/static/storage-file-layout.html
|
Since we are only checking for the one file, we no longer need - if [ -z "$(ls -A "$PGDATA"/PG_VERSION)" ]; then
+ if [ -s "$PGDATA/PG_VERSION" ]; then |
|
@yosifkit Ah true. Changed! :) |
|
LGTM |
1 similar comment
|
LGTM |
tianon
added a commit
that referenced
this pull request
Jul 20, 2015
Check that vol actually contains DB files, as opposed to a non-empty dir.
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Jul 21, 2015
- `logstash`: 1.5.3 - `mariadb`: switch 10.0 to jessie (MariaDB/mariadb-docker#17) - `mongo`: 3.1.6 - `postgres`: use `PG_VERSION` instead of just empty directory for "database detection" (docker-library/postgres#72)
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
- `logstash`: 1.5.3 - `mariadb`: switch 10.0 to jessie (MariaDB/mariadb-docker#17) - `mongo`: 3.1.6 - `postgres`: use `PG_VERSION` instead of just empty directory for "database detection" (docker-library/postgres#72)
anthr76
added a commit
to anthr76/infra
that referenced
this pull request
May 3, 2021
docker-library/postgres#72 Signed-off-by: anthr76 <hello@anthonyrabbito.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of fix for mounting persistent disks on Google Cloud Compute containers - fresh disks have a
lost+founddirectory, causing the old check to fail withThe second part of the fix requires the GCE user to adjust
PGDATAto a subdirectory within the mounted persistent disk. If theinitdbcommand is run directly on the mount point root, it fails, complaining that it is bad practice to have the database there. Reference thread.The notice to adjust
PGDATAshould be in the docs for postgres-docker.I feel we should not make it mandatory for
PGDATAto auto-create a subdirectory at allVOLUMEmountpoints, as the mounted point might already be a subdirectory in the host system.