Keep postgres static libraries in Alpine images #764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to give a simple example |
FROM postgres:12.4-alpine
RUN apk add --no-cache \
bsd-compat-headers \
clang \
flex \
fortify-headers \
gcc \
git \
libedit-dev \
libxml2-dev \
libxslt-dev \
linux-headers \
llvm10-dev \
make \
musl-dev \
openssl-dev
ARG REPMGR_VERSION=master
RUN git clone --branch "${REPMGR_VERSION}" https://github.com/2ndQuadrant/repmgr
WORKDIR /tmp/repmgr
RUN ./configure
RUN make USE_PGXS=1 install |
|
Thanks! I had to change |
tianon
reviewed
Sep 25, 2020
Do not remove static postgres libraries from Alpine based images. This add near 1.4MB to image size, but allow to complie some extentions like repmgr without errors
|
Have updated PR to not delete empty lines |
|
Nice work, thank you! LGTM 👍 |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Sep 26, 2020
Changes: - docker-library/postgres@b80fcb5: Merge pull request docker-library/postgres#764 from maytech/master - docker-library/postgres@04bf35f: Keep postgres static libraries in Alpine images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not remove static postgres libraries from Alpine based images.
This add near 1.4MB to image size, but allow to complie some extentions
like repmgr without errors