Skip to content

more sane way of starting and stopping postgres server using pg_ctl #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2015
Merged

more sane way of starting and stopping postgres server using pg_ctl #80

merged 2 commits into from
Aug 21, 2015

Conversation

renzok
Copy link
Contributor

@renzok renzok commented Aug 4, 2015

as recommended per postgresql docs and implemented according to http://stackoverflow.com/questions/28244869/creating-a-table-in-single-user-mode-in-postgres

The -w option of pg_ctl waits until server is started or stopped. This avoids the 30 second countdown and repeatedly querying database.

mkdir -p "$PGDATA"
chown -R postgres "$PGDATA"
mkdir -p "${PGDATA}"
chown -R postgres "${PGDATA}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The curly braces are unnecessary here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, habit of mine and my editor highlights them the better, will take that back

@renzok
Copy link
Contributor Author

renzok commented Aug 21, 2015

hope this commit makes this pull request acceptable

@yosifkit
Copy link
Member

LGTM

1 similar comment
@tianon
Copy link
Member

tianon commented Aug 21, 2015

LGTM

tianon added a commit that referenced this pull request Aug 21, 2015
more sane way of starting and stopping postgres server using pg_ctl
@tianon tianon merged commit 486194c into docker-library:master Aug 21, 2015
yosifkit added a commit to infosiftr/stackbrew that referenced this pull request Aug 21, 2015
RichardScothern pushed a commit to RichardScothern/official-images that referenced this pull request Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants