Export POSTGRES_USER and POSTGRES_DB vars in entrypoint #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows them to be used from /docker-entrypoint-initdb.d/*.sh scripts
|
Good call; LGTM 👍 |
|
LGTM |
yosifkit
added a commit
that referenced
this pull request
Aug 26, 2015
Export POSTGRES_USER and POSTGRES_DB vars in entrypoint
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Aug 26, 2015
- `mariadb`: fix `MYSQL_ALLOW_EMPTY_PASSWORD` feature (MariaDB/mariadb-docker#19) - `mongo`: 3.1.7 - `percona`: fix `MYSQL_ALLOW_EMPTY_PASSWORD` feature (docker-library/percona#8) - `postgres`: export `POSTGRES_USER` and `POSTGRES_DB` for initdb scripts (docker-library/postgres#84)
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
- `mariadb`: fix `MYSQL_ALLOW_EMPTY_PASSWORD` feature (MariaDB/mariadb-docker#19) - `mongo`: 3.1.7 - `percona`: fix `MYSQL_ALLOW_EMPTY_PASSWORD` feature (docker-library/percona#8) - `postgres`: export `POSTGRES_USER` and `POSTGRES_DB` for initdb scripts (docker-library/postgres#84)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it now stands the
$POSTGRES_USERand$POSTGRES_DBvariables aren't visible in/docker-entrypoint-initdb.d/*.shscripts unless they have been set explicitly with-ein thedocker runcommand or withENVin a derivedDockerfile.This change allows those variables to be seen in the
*.shscripts. Without this change, any*.shscripts that want to follow the same conventions as thepostgresbase image need to duplicate this code:I ran into this while trying to implement postgis/docker-postgis#4 (Enable PostGIS extensions on default database).