Skip to content

Why there is no '--enable-optimizations' for python 2.7 images? #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gcavalcante8808 opened this issue Dec 2, 2019 · 4 comments · Fixed by #440
Closed

Why there is no '--enable-optimizations' for python 2.7 images? #436

gcavalcante8808 opened this issue Dec 2, 2019 · 4 comments · Fixed by #440
Labels
question Usability question, not directly related to an error with the image Request Request for image modification or feature

Comments

@gcavalcante8808
Copy link

Hello Folks,

Looks like the python 2.7 images aren't using the '--enable-optimizations' in the configure step of python compilation (

python/2.7/buster/slim/Dockerfile

Line 62 in cf68ae0

&& ./configure \
). Is there any problem or reason to do so?

I just built an image locally with the flag and it worked.

Thanks in advance.
@wglambert
Copy link

There was a large discussion on this in #160

And a pr close in #357 (comment) due to the extraordinarily longer build times

@tianon
Copy link
Member

tianon commented Dec 2, 2019

If you look at the build logs for your local build with the flag added right after ./configure ... runs, you'll probably see something to the effect of "ignoring unknown flag" because Python 2.x doesn't actually support/use this flag (and thus ignores it, which is why your build still works).

@wglambert wglambert added question Usability question, not directly related to an error with the image Request Request for image modification or feature labels Dec 4, 2019
@blopker
Copy link
Contributor

blopker commented Dec 18, 2019

It looks like the 2.7 Dockerfiles are built off the "caveman" template. This template does not seem to have the optimization flag. We build our own Pythons so I do know that 2.7 does support the optimization flag. Maybe it should be added to the caveman template.

@tianon tianon mentioned this issue Dec 18, 2019
Merged
@tianon
Copy link
Member

tianon commented Dec 18, 2019

I could've sworn this wasn't supported back when we did #357 but either way, I've got #440 open with this change now. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Usability question, not directly related to an error with the image Request Request for image modification or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add "--enable-optimizations" on Python 2.7 infosiftr/python
4 participants
@tianon @gcavalcante8808 @blopker @wglambert